Duplicate css properties for navbar #647

Open
opened 1 month ago by EvelynTSMG · 2 comments

.following.bar, #navbar has two background-color properties:

background-color: #2185d0 !important; /*in codeberg.css */
background-color: var(--color-primary); /*in theme-codeberg-auto.css */

Note: var(--color-primary) is equivalent to #2185d0.

Is this intentional? If so, assumingly to add !important, why not use var(--color-primary) instead of #2185d0?

Similarly, border-bottom: none !important; is included in both files.

Sorry for wasting your time if this was indeed intentional

`.following.bar, #navbar` has two `background-color` properties: ```css background-color: #2185d0 !important; /*in codeberg.css */ background-color: var(--color-primary); /*in theme-codeberg-auto.css */ ``` Note: `var(--color-primary)` is equivalent to `#2185d0`. Is this intentional? If so, assumingly to add `!important`, why not use `var(--color-primary)` instead of `#2185d0`? Similarly, `border-bottom: none !important;` is included in both files. Sorry for wasting your time if this was indeed intentional
n commented 4 weeks ago
Collaborator

.following.bar, #navbar has two background-color properties:

background-color: #2185d0 !important; /*in codeberg.css */
background-color: var(--color-primary); /*in theme-codeberg-auto.css */

Note: var(--color-primary) is equivalent to #2185d0.

Is this intentional? If so, assumingly to add !important, why not use var(--color-primary) instead of #2185d0?

I think that might've been done so that the navbar color persists even when using a non-Codeberg theme.

> `.following.bar, #navbar` has two `background-color` properties: > ```css > background-color: #2185d0 !important; /*in codeberg.css */ > background-color: var(--color-primary); /*in theme-codeberg-auto.css */ > ``` > Note: `var(--color-primary)` is equivalent to `#2185d0`. > > Is this intentional? If so, assumingly to add `!important`, why not use `var(--color-primary)` instead of `#2185d0`? > I think that might've been done so that the navbar color persists even when using a non-Codeberg theme.
Collaborator

This is a slow project, we want to get rid of most of the codeberg.css in the build-deploy-gitea repo. The theme-codeberg-auto.css is new, and we're migrating to it. As soon as we are done, only that one will take effect and the navbar colour will change with the theme.

We're rather slow with that, though. We have to also revert some patches to the navbar, and for that we have to make sure the links are somewhere else, e.g. in the footer and ... well, it's a complicated dependency mess.

This is a slow project, we want to get rid of most of the codeberg.css in the build-deploy-gitea repo. The theme-codeberg-auto.css is new, and we're migrating to it. As soon as we are done, only that one will take effect and the navbar colour will change with the theme. We're rather slow with that, though. We have to also revert some patches to the navbar, and for that we have to make sure the links are somewhere else, e.g. in the footer and ... well, it's a complicated dependency mess.
rwa added the
codeberg
label 6 days ago
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Codeberg/Community#647
Loading…
There is no content yet.