CRSF token expiry causes text loss on issue 'Save' #600

Open
opened 2 months ago by circlebuilder · 3 comments

I just reported a bug on the Gitea issue tracker for something I experienced here on Codeberg multiple times now (not only in the 1.16 release of Gitea, but before that too).

The buggy behavior is that after editing (adding text below) existing issue, which contains already a bunch of text, the update to the issue is entirely lost without an error being shown.

Here's the issue URL: https://github.com/go-gitea/gitea/issues/19126

I just reported a bug on the Gitea issue tracker for something I experienced here on Codeberg multiple times now (not only in the 1.16 release of Gitea, but before that too). The buggy behavior is that after editing (adding text below) existing issue, which contains already a bunch of text, the update to the issue is entirely lost without an error being shown. Here's the issue URL: https://github.com/go-gitea/gitea/issues/19126
Collaborator

Do you have the issue open for a longer time by chance? From time to time my CSRF token expires and I have to click back and forth to restore the content again. (Tracked upstream at https://github.com/go-gitea/gitea/issues/17850).

I suppose a similar timeout happens when you edit an issue for too long, and maybe it's not gracefully handled.

If this might be an option, we can check if this is true (I don't know the exact timeout, but we could check if an edit fails silently without an error when the CSRF token is definitely expired, after a day or so).

Do you have the issue open for a longer time by chance? From time to time my CSRF token expires and I have to click back and forth to restore the content again. (Tracked upstream at https://github.com/go-gitea/gitea/issues/17850). I suppose a similar timeout happens when you edit an issue for too long, and maybe it's not gracefully handled. If this might be an option, we can check if this is true (I don't know the exact timeout, but we could check if an edit fails silently without an error when the CSRF token is definitely expired, after a day or so).
fnetX added the
bug
question
gitea-related
upstream
labels 2 months ago
Poster

Yes, that must be it! I think on the last occurrence I had the issue open between 20 to 30 mins. Thank you. I will reference your comment on the other issue.

Yes, that must be it! I think on the last occurrence I had the issue open between 20 to 30 mins. Thank you. I will reference your comment on the other issue.
Poster

My upstream issue is closed with a cross-ref to https://github.com/go-gitea/gitea/issues/17850 I will update the issue title, and you might close this unless you feel it is worthwhile to continue tracking this nasty bug.

My upstream issue is closed with a cross-ref to https://github.com/go-gitea/gitea/issues/17850 I will update the issue title, and you might close this unless you feel it is worthwhile to continue tracking this nasty bug.
circlebuilder changed title from Updated issue text lost upon 'Save' to CRSF token expiry causes text loss on issue 'Save' 2 months ago
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.