"arc-green" theme color inconsistancy #434

Closed
opened 3 months ago by mehrad · 5 comments
mehrad commented 3 months ago

Two points:

  1. The "arc-green" is actually blue (I briefly touched upon it in #431)
  2. The blue color is not even consistant. As you can see in the Gif below, when I click on the textbox, the border is blue, when I click on the drop-down, the border is green, and when I switch to textbox without closing the drop-down and then switch back to dropdown and unhover the drop-down, the border is blue AND green.

a gif to show color inconsistancy

Two points: 1. The "arc-green" is actually blue (I briefly touched upon it in #431) 2. The blue color is not even consistant. As you can see in the Gif below, when I click on the textbox, the border is blue, when I click on the drop-down, the border is green, and when I switch to textbox without closing the drop-down and then switch back to dropdown and unhover the drop-down, the border is blue AND green. ![a gif to show color inconsistancy](https://codeberg.org/attachments/24699df5-0d3b-4ee3-8314-b7e33cf8cf5a)
Collaborator

Yeah ... well, that's my fault. I did a dirty override to revert some upstream colour changes to match our codeberg tones (was really looking odd), but I'm not yet done with it (should go into our Gitea fork directly, not in the deployment, didn't had the time to finish this before 1.14 deployment).
4b68de7caa is the evil commit

@6543 yeah I know you promised someone would notice this before I finish haha ...

Yeah ... well, that's my fault. I did a dirty override to revert some upstream colour changes to match our codeberg tones (was really looking odd), but I'm not yet done with it (should go into our Gitea fork directly, not in the deployment, didn't had the time to finish this before 1.14 deployment). https://codeberg.org/Codeberg/build-deploy-gitea/commit/4b68de7caabcd0639cef47bb2de794a699d0ee1c is the evil commit @6543 yeah I know you promised someone would notice this before I finish haha ...
fnetX added the
gitea-related
bug
labels 3 months ago
fnetX self-assigned this 3 months ago
fnetX added this to the (deleted) milestone 3 months ago
Collaborator

Just to clarify: arc-green is actually a dark greenish theme, the blue colours are overrides for the light theme that also apply to the dark theme and break it.

Just to clarify: arc-green is actually a dark greenish theme, the blue colours are overrides for the light theme that also apply to the dark theme and break it.

The folder icons in repos are also still green.

The folder icons in repos are also still green.
Poster

@fossdd To be honest, I actually like that, because if those are also blue, then everything (folder names, commit messages, commit hashes, user names, and basically enthing that is a link) would become monochromic.

@fossdd To be honest, I actually like that, because if those are also blue, then everything (folder names, commit messages, commit hashes, user names, and basically enthing that is a link) would become monochromic.
fnetX closed this issue 3 months ago
Collaborator

Ahh auto-close ...

Will be deployed soon.

To be honest, I actually like that, because if those are also blue, then everything (folder names, commit messages, commit hashes, user names, and basically enthing that is a link) would become monochromic.

#392 (having a dark-theme that matches Codeberg colours) would be really neat - but making arc-green a blue theme does not sound like a really good idea.

Ahh auto-close ... Will be deployed soon. > To be honest, I actually like that, because if those are also blue, then everything (folder names, commit messages, commit hashes, user names, and basically enthing that is a link) would become monochromic. #392 (having a dark-theme that matches Codeberg colours) would be really neat - but making arc-green a blue theme does not sound like a really good idea.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.