#260 Support for `Draft Merge Requests`

Open
opened 1 week ago by kreyren · 7 comments
kreyren commented 1 week ago

Github has Draft merge requests which helps with optimizing CI by triggering the build only when the merge request is ready for the review and coordinating the works while preventing unwanted merges.

Proposing such feature implemented here

Github has `Draft merge requests` which helps with optimizing CI by triggering the build only when the merge request is ready for the review and coordinating the works while preventing unwanted merges. Proposing such feature implemented here
6543 added the
enhancement
label 1 week ago
hw commented 1 week ago
Owner

PRs are marked as draft if the subject line starts with WIP: or [WIP]:

PRs are marked as draft if the subject line starts with `WIP:` or `[WIP]:`
hw commented 1 week ago
Owner

@lhinderberger : would it make sense to mention+discuss the WIP prefix in the documentation?

@lhinderberger : would it make sense to mention+discuss the WIP prefix in the documentation?
kreyren commented 1 week ago
Poster

@hw the WIP prefix is kinda janky having a button for this that changes the merge request status from Open to Draft that prevents merge would be preferrable

@hw the WIP prefix is kinda janky having a button for this that changes the merge request status from Open to Draft that prevents merge would be preferrable
lhinderberger commented 1 week ago
Collaborator

@hw Absolutely - Let’s handle this as a part of Codeberg/Documentation#68

@kreyren - Yes, a better UI for that would be good. Can you look this up in Gitea’s issue tracker and see if there already exists such a feature request (or PR)? If not, it would be great to write one and add a link to this discussion :)

@hw Absolutely - Let's handle this as a part of Codeberg/Documentation#68 @kreyren - Yes, a better UI for that would be good. Can you look this up in Gitea's issue tracker and see if there already exists such a feature request (or PR)? If not, it would be great to write one and add a link to this discussion :)
kreyren commented 1 week ago
Poster

Was unable to find a relevant issue, submitted https://github.com/go-gitea/gitea/issues/12874

Was unable to find a relevant issue, submitted https://github.com/go-gitea/gitea/issues/12874
lhinderberger commented 1 week ago
Collaborator

@kreyren - I hope I didn’t lead you on the wrong path there: I meant a PR or issue in regards of improving the UX of marking a PR as a draft. The functionality is already there, it’s just the UI that could be improved a little.

As you did write that marking PRs with WIP wouldnt prevent merges, I was wondering whether that feature failed to function when you tried it or whether this is was misunderstanding?

@kreyren - I hope I didn't lead you on the wrong path there: I meant a PR or issue in regards of improving the UX of marking a PR as a draft. The functionality is already there, it's just the UI that could be improved a little. As you did write that marking PRs with WIP wouldnt prevent merges, I was wondering whether that feature failed to function when you tried it or whether this is was misunderstanding?
kreyren commented 1 week ago
Poster

Ah the WIP didn’t work for me on the Gitea instance +- 1 month ago when i was trying it

image

Works now so just the UX could be probably improved.

I got apparently banned from gitea repository (no reason was provided) so i created https://codeberg.org/RXT0130/reytea and provide the contributions for grabs.

Ah the WIP didn't work for me on the Gitea instance +- 1 month ago when i was trying it ![image](https://codeberg.org/attachments/e91ab6d0-f600-4aac-858a-32497ededf67) Works now so just the UX could be probably improved. I got apparently banned from gitea repository (no reason was provided) so i created https://codeberg.org/RXT0130/reytea and provide the contributions for grabs.
Sign in to join this conversation.
No Milestone
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.