#163 Missing translation on mail verification

Open
opened 2 months ago by fnetX · 4 comments
fnetX commented 2 months ago

Hey everyone,

the verification mail lacks translation. Some parts of it are in German.

Subject: Bestätige deine E-Mail-Adresse

Message:

Hi fnetX,

Please click the following link to verify your email address within 3 Stunden:

https://codeberg.org/user/activate_email?code=foo&email=bar

Not working? Try copying and pasting it to your browser.

Welcome to Codeberg.org!

Hey everyone, the verification mail lacks translation. Some parts of it are in German. Subject: ~~Bestätige deine E-Mail-Adresse~~ Message: > Hi fnetX, > > Please click the following link to verify your email address within ~~3 Stunden~~: > > https://codeberg.org/user/activate_email?code=foo&email=bar > > Not working? Try copying and pasting it to your browser. > > Welcome to Codeberg.org! >
fnetX commented 2 months ago
Poster

... or is it actually translated but the rest of it lives in the custom (untranslated) email template?

That's what I assume when I look at https://codeberg.org/Codeberg/build-deploy-gitea/src/branch/master/local_patches/template_changes.diff but nevertheless this behaviour seems quite strange ...

Update: Okay, excuse the mess ... indeed, it's correctly translated into German but rest of the mail template is not. I'm okay with that, but I'll leave this issue open for discussion. May be someone wants to make the necessary changes in order to have a full translation?

... or is it actually translated but the rest of it lives in the custom (untranslated) email template? That's what I assume when I look at https://codeberg.org/Codeberg/build-deploy-gitea/src/branch/master/local_patches/template_changes.diff but nevertheless this behaviour seems quite strange ... Update: Okay, excuse the mess ... indeed, it's *correctly* translated into German but rest of the mail template is not. I'm okay with that, but I'll leave this issue open for discussion. May be someone wants to make the necessary changes in order to have a full translation?
hw commented 2 months ago
Owner

Good catch, thank you! Pull request to templates welcome!

Good catch, thank you! Pull request to templates welcome!
fnetX commented 2 months ago
Poster

I can't exactly see how to translate those complete templates ... I think separating the part before and after the variables would only cause some issues with certain languages where syntax is different, right?

I can't exactly see how to translate those complete templates ... I think separating the part before and after the variables would only cause some issues with certain languages where syntax is different, right?
hw commented 1 month ago
Owner

mh, yes, probably

mh, yes, probably
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.