Can't update metadata of repository with name containing dots

mro commented

2023-10-05 07:17:38 +00:00

Comment

...und dann kann man in den Meta-Daten (Beschreibung etc.) nichts mehr ändern.

Blöd bei https://codeberg.org/jugendhacktlab.qdrei.info.

Der '.' würde mir schon reichen. Rausnehmen mag ich den nicht.

Viele Grüße,
@mro

### Comment ...und dann kann man in den Meta-Daten (Beschreibung etc.) nichts mehr ändern. Blöd bei https://codeberg.org/jugendhacktlab.qdrei.info. Der '.' würde mir schon reichen. Rausnehmen mag ich den nicht. Viele Grüße, @mro

mro changed title from ~~Strengere Org-Name-Regeln machen existierende ungültig~~ to Bug: Strengere Org-Name-Regeln machen existierende ungültig

2023-10-05 07:19:49 +00:00

fnetX added the

enhancement

contribution welcome

s/Gitea/Forgejo

labels 2023-10-05 09:06:58 +00:00

fnetX commented

2023-10-05 09:07:03 +00:00

Owner

Allowing dots in the username causes all kinds of problems. For example, users get repeatedly confused about the fact that their Codeberg Pages don't work with dots in the username. So the best option is to prevent users from signing up using letters that prevent them from using certain services we provide.

To me, it sounds like a bug or at least unwanted behaviour that you obviously cannot change any settings while keeping the name. It might be good to extend the code that only prevents name changes with a dot, but ignores the name when it remains unchanged.

Allowing dots in the username causes all kinds of problems. For example, users get repeatedly confused about the fact that their Codeberg Pages don't work with dots in the username. So the best option is to prevent users from signing up using letters that prevent them from using certain services we provide. To me, it sounds like a bug or at least unwanted behaviour that you obviously cannot change any settings while keeping the name. It might be good to extend the code that only prevents name changes with a dot, but ignores the name when it remains unchanged.

mro commented

2023-10-05 14:19:01 +00:00

Poster

Hi @fnetX,

I understand that dots in names may conflict with names as sudomains for pages (argh, why actually? But that's a different story)

But rendering existing usernames invalid when introducing a new feature is a bit rude IMO.

What about being explicit and saying "No pages for dotname users"?

Not every user may be interested in a page.

Hi @fnetX, I understand that dots in names may conflict with names as sudomains for pages (argh, why actually? But that's a different story) But rendering existing usernames invalid when introducing a new feature is a bit rude IMO. What about being explicit and saying "No pages for dotname users"? Not every user may be interested in a page.

n0toose commented

2023-10-06 00:19:40 +00:00

Collaborator

Here's the best part: This shouldn't happen if you did not change your username in any way and just left it as-is. HandleUsernameChange should not be called - so I am not sure how we are even reaching the part where it errors out to begin with. This requires some further investigation - can I confirm the error again, just to be 100% sure?

(argh, why actually? But that's a different story)

Subdomain logic, as well as the fact that i.e. firstpart.secondpart.codeberg.page for the user firstpart.secondpart causes trouble with wildcard certificates IIRC.

Not every user may be interested in a page.

One detail that @fnetX left out is that this would break features like RSS feeds or the one that shows your SSH keys to people (e.g. https://codeberg.org/mro.rss or https://codeberg.org/mro.keys), as well as the feature being intended as an additional clunky anti-spam measure. Dots in namespaces is a feature that other forges like GitLab or GitHub don't have, and that causes unintended breakage with third-party applications (like pages) It's such a little tiny detail, but it's essentially making itself out to be a nightmare to the point where it wasn't very worth it - we had to regularly answer to inquiries about this too.

However, I agree that it's definitely rude and that forcing users to change their repository's names is an unintentional behavior - I checked all cases involving whether the user is allowed to change their username as I was changing the environment variable, but I did not assume that the other fields would be a problem because of the aforementioned excerpt.

Here's the best part: This shouldn't happen if you did not change your username in any way and just left it as-is. `HandleUsernameChange` should not be called - so I am not sure how we are [even reaching the part where it errors out to begin with](https://codeberg.org/forgejo/forgejo/src/commit/578d79b44955c4fb47ed4ead5b102c7e7b40cc2d/modules/web/middleware/binding.go#L138-L143). This requires some further investigation - can I confirm the error again, just to be 100% sure? > (argh, why actually? But that's a different story) Subdomain logic, as well as the fact that i.e. `firstpart.secondpart.codeberg.page` for the user `firstpart.secondpart` causes trouble with wildcard certificates IIRC. > Not every user may be interested in a page. One detail that @fnetX left out is that this would break features like RSS feeds or the one that shows your SSH keys to people (e.g. `https://codeberg.org/mro.rss` or `https://codeberg.org/mro.keys`), as well as the feature being intended as an additional clunky anti-spam measure. Dots in namespaces is a feature that other forges like GitLab or GitHub don't have, and that causes unintended breakage with third-party applications (like pages) It's such a little tiny detail, but it's essentially making itself out to be a nightmare to the point where it wasn't very worth it - we had to regularly answer to inquiries about this too. However, I agree that it's definitely rude and that forcing users to change their repository's names is an unintentional behavior - I checked all cases involving whether the user is allowed to change their username as I was changing the environment variable, but I did not assume that the other fields would be a problem because of the aforementioned excerpt.

n0toose added the

bug

label 2023-10-06 00:19:49 +00:00

n0toose changed title from ~~Bug: Strengere Org-Name-Regeln machen existierende ungültig~~ to Can't update metadata of repository with name containing dots

2023-10-06 00:20:50 +00:00

mro commented

2023-10-06 07:09:07 +00:00

Poster

@n0toose e voila, you're welcome. (Intended to change the 'Beschreibung')

P.S.: my life doesn't depend on the dots - it's just consistent brand naming and thus was my first choice back then. I avoid to invent arbitrary things.

@n0toose e voila, you're welcome. (Intended to change the 'Beschreibung') P.S.: my life doesn't depend on the dots - it's just consistent brand naming and thus was my first choice back then. I avoid to invent arbitrary things.

2023-10-06-090658-_--_screen_x250.local.png

89 KiB

👍 1

n0toose commented

2023-10-06 14:02:46 +00:00

Collaborator

Thank you.

Can't update metadata of repository with name containing dots #1312

Comment