replace two old logo svg files #15

Merged
hw merged 2 commits from :new-logo into master 2 years ago
mray commented 2 years ago

The new svg files are a new logo proposal from me. See Codeberg/Design#3

It should look something like this:

image

The new svg files are a new logo proposal from me. See https://codeberg.org/Codeberg/Design/issues/3#issuecomment-55937 It should look something like this: ![image](/attachments/eff367f6-b151-4e05-b58f-a3c3cd4c30b5)
111 KiB
Owner

Hm, seems like this breaks the favicon & the logo:
image

That seems to be a bigger issue as it relates to lots of stuff in the Makefile. @hw maybe we want to convert the images manually instead of with the Makefile? It seems to me like the logo changes very rarely & if it changes the change will be that drastic that the logic needs to change too...

Hm, seems like this breaks the favicon & the logo: ![image](/attachments/0f59d5e2-4a6d-4d97-ab48-1272fe1db1f8) That seems to be a bigger issue as it relates to lots of stuff in the Makefile. @hw maybe we want to convert the images manually instead of with the Makefile? It seems to me like the logo changes very rarely & if it changes the change will be that drastic that the logic needs to change too...
Owner

If you add a codeberg-light.svg (codeberg.svg without the text), this should work.

If you add a `codeberg-light.svg` (`codeberg.svg` without the text), this should work.
hw commented 2 years ago
Owner

The convention for the master SVG was to put things that show up in different sizes only onto layers layer2 and layer3:

  • For large pictures, all layers are rendered,
  • for medium size, layer3 is removed,
  • for small size (favicon etc), both layer2 and layer3 are removed.
The convention for the master SVG was to put things that show up in different sizes only onto layers `layer2` and `layer3`: - For large pictures, all layers are rendered, - for medium size, `layer3` is removed, - for small size (favicon etc), both `layer2` and `layer3` are removed.
Owner

Hm, does it cut the document to its contents automatically?

Hm, does it cut the document to its contents automatically?
hw commented 2 years ago
Owner

--export-area-drawing does the trick. If this doesn't work with the new content for any reason, using your approach of separate images instead of layers works perfectly well, too. What would you prefer?

`--export-area-drawing` does the trick. If this doesn't work with the new content for any reason, using your approach of separate images instead of layers works perfectly well, too. What would you prefer?
Owner

I think I'd prefer to avoid SVG conversion with Inkscape completely, as it's probably the least portable of the whole deployment process. ImageMagick works well in the command line, on headless servers and in Docker, but Inkscape requires so many dependencies that automating it would be pretty complex...

But, if we want to keep it, I guess the layer-based approach is fine too.

I think I'd prefer to avoid SVG conversion with Inkscape completely, as it's probably the least portable of the whole deployment process. ImageMagick works well in the command line, on headless servers and in Docker, but Inkscape requires so many dependencies that automating it would be pretty complex... But, if we want to keep it, I guess the layer-based approach is fine too.
hw commented 2 years ago
Owner

Inkscape on headless works via xvfb-run, lots of dependencies tho and not sure how stable the API is. ImageMagick would be cool but lacks good SVG support.

No strong feelings, either approach is fine: happy to merge if you say it's time to do so.

Inkscape on headless works via xvfb-run, lots of dependencies tho and not sure how stable the API is. ImageMagick would be cool but lacks good SVG support. No strong feelings, either approach is fine: happy to merge if you say it's time to do so.
Owner

I'd prefer if @mray could add a "codeberg-dark.svg" without text (I can't commit to this PR branch), that should require the least amount of work on all sides right now.

I'd prefer if @mray could add a "codeberg-dark.svg" without text (I can't commit to this PR branch), that should require the least amount of work on all sides right now.
Owner

Ehm, I obviously meant codeberg-light.svg ,

Ehm, I obviously meant codeberg-light.svg ,
hw commented 2 years ago
Owner

ok

ok
Owner

Oh, and I've now thrown out Inkscape completely from the Makefile in #16, which means that the SVGs now need to be cropped already (File, Document settings, Crop to contents (or something similar)).

Also, in the attachment in Codeberg/Design#3 the logo has a white background on the circle for the light version on dark background. This would be relevant for the favicon in a dark-themed browser.

Oh, and I've now thrown out Inkscape completely from the Makefile in #16, which means that the SVGs now need to be cropped already (File, Document settings, Crop to contents (or something similar)). Also, in the attachment in https://codeberg.org/Codeberg/Design/issues/3#issuecomment-55937 the logo has a white background on the circle for the light version on dark background. This would be relevant for the favicon in a dark-themed browser.
Owner
Test: #16 (see https://codeberg.org/Codeberg/Community/issues/189)
Owner

Alright, I have no idea what that was... I meant the attachment in Codeberg/Design#3

Alright, I have no idea what that was... I meant the attachment in https://codeberg.org/Codeberg/Design/issues/3#issuecomment-55937
Poster

I'd prefer if @mray could add a "codeberg-dark.svg" without text (I can't commit to this PR branch), that should require the least amount of work on all sides right now.

Here I attached an svg that looks just like this:
image

Just let me know when you need different versions or sizes. Hope it helps.

> I'd prefer if @mray could add a "codeberg-dark.svg" without text (I can't commit to this PR branch), that should require the least amount of work on all sides right now. Here I attached an svg that looks just like this: ![image](/attachments/9465a6f6-1674-4019-b626-a2a7b83e64d9) Just let me know when you need different versions or sizes. Hope it helps.
2.0 KiB
Poster

hm… gitea seems to not like the attached svg next to a png? next try:

hm… gitea seems to not like the attached svg next to a png? next try:
Poster

Gitea does not allow the file extension to be uploaded. :(

Gitea does not allow the file extension to be uploaded. :(
Owner

You should be able to upload it directly at https://codeberg.org/mray/build-deploy-gitea/src/branch/new-logo. The PR always refers to a branch, so when you commit a new file to the branch, the PR will also reflect the changes.

You should be able to upload it directly at https://codeberg.org/mray/build-deploy-gitea/src/branch/new-logo. The PR always refers to a branch, so when you commit a new file to the branch, the PR will also reflect the changes.
Poster

Ok thanks. Did just that.

Ok thanks. Did just that.
Owner

Okay, I added some smaller fixes in #16. This can be merged now, then I'll rebase #16 onto master so that one can be merged too. :)

Okay, I added some smaller fixes in #16. This can be merged now, then I'll rebase #16 onto master so that one can be merged too. :)
hw closed this pull request 2 years ago
The pull request has been merged as 6ad666eb14.
Sign in to join this conversation.
Loading…
There is no content yet.