Extension did not seem to be loaded #55

Closed
opened 3 months ago by earnestma · 4 comments

Problem

On https://feather.wiki, opening a page in a new tab does not seem to show the search extension.

Expected Behavior

The search extension should be shown.

Steps to Reproduce

  1. Open https://feather.wiki or https://feather.wiki/?page=faqs, for example
  2. Open another page in a new tab using the sidebar links (until reloaded)
  3. Search extension does not appear in that tab (no console errors)

Screen recording: https://cloud.earne.link/s/qafX25YjgwaYqgo

Details

  • I am using this build: Dove
  • I am using this version: 1.3.0
  • I am using this browser: Firefox 101.0.1 (MacOS 12.4)
## Problem On https://feather.wiki, opening a page in a new tab does not seem to show the search extension. ## Expected Behavior The search extension should be shown. ## Steps to Reproduce 1. Open https://feather.wiki or https://feather.wiki/?page=faqs, for example 2. Open another page in a new tab using the sidebar links (until reloaded) 3. Search extension does not appear in that tab (no console errors) Screen recording: https://cloud.earne.link/s/qafX25YjgwaYqgo ## Details - **I am using this build:** Dove - **I am using this version:** 1.3.0 - **I am using this browser:** Firefox 101.0.1 (MacOS 12.4)
earnestma added the
bug
label 3 months ago
Owner

That's very strange, thanks for reporting it! It appears that refreshing the tab does load the extension, but it's confusing why it's behaving this way at all... Maybe Firefox isn't loading the whole HTML page again? Very odd.

I'll see if I can figure out what's going on, but I'm not confident that I'll be successful.

That's very strange, thanks for reporting it! It appears that refreshing the tab does load the extension, but it's confusing why it's behaving this way at all... Maybe Firefox isn't loading the whole HTML page again? Very odd. I'll see if I can figure out what's going on, but I'm not confident that I'll be successful.
Alamantus added the
help wanted
label 3 months ago

I had a similar issue while working on an extension for #39. Sometimes, after saving Custom JS and refreshing, the code just didn't run. No errors in the console. Refreshing fixed the issue. I only had one tab of that FeatherWiki open, but I did have a different FeatherWiki open at the same time. Both FeatherWikis are being hosted by TiddlyHost.

I had a similar issue while working on an extension for #39. Sometimes, after saving Custom JS and refreshing, the code just didn't run. No errors in the console. Refreshing fixed the issue. I only had one tab of that FeatherWiki open, but I did have a different FeatherWiki open at the same time. Both FeatherWikis are being hosted by TiddlyHost.
Owner

One reason you might be experiencing this problem @pipythonmc is that the render event in Choo does not trigger when the page first loads. You'll need to add a DOMCONTENTLOADED emitter event as well. Check out the setup on the Search extension to see if that helps: https://codeberg.org/Alamantus/FeatherWiki/src/branch/main/extensions/search.js#L28

The issue of extensions not loading when opening a link in a new tab on Firefox is still a complete mystery to me though.

One reason you might be experiencing this problem @pipythonmc is that the `render` event in Choo does not trigger when the page first loads. You'll need to add a `DOMCONTENTLOADED` emitter event as well. Check out the setup on the Search extension to see if that helps: https://codeberg.org/Alamantus/FeatherWiki/src/branch/main/extensions/search.js#L28 The issue of extensions not loading when opening a link in a new tab on Firefox is still a complete mystery to me though.
Alamantus added this to the 1.4.0 milestone 2 weeks ago
Owner

Hi @earnestma, all of the official extensions from the Feather Wiki site have been updated with a more reliable loading process, and in my testing, the issue of Firefox not loading extensions when opening in a new tab is no longer an issue!

Please let me know if you still experience this problem after updating your extensions—I will re-open the issue if necessary.

Hi @earnestma, all of the official extensions from the Feather Wiki site have been updated with a more reliable loading process, and in my testing, the issue of Firefox not loading extensions when opening in a new tab is no longer an issue! Please let me know if you still experience this problem after updating your extensions—I will re-open the issue if necessary.
Alamantus closed this issue 1 week ago
Sign in to join this conversation.
Loading…
There is no content yet.