After a save the the "Recent" tab becomes empty #134

Closed
opened 2023-10-23 17:21:46 +00:00 by sbaird · 7 comments

Describe the problem

I'm guessing there's an attribute used by the "Recent" tab that isn't being persisted.

To Reproduce

  1. Modify some pages
  2. Observe Recent tab
  3. Now save
  4. The saved Feather Wiki has an empty Recent tab

Expected behavior

The items listed in the recent tab should persist after a save.

Details (please complete the following information)

  • I am using this build: Warbler
  • I am using this version: 1.7.0
  • I am using this browser: Chrome

Additional context

I might be confused about the expected behavior, but it seems like the Recent tab being empty after a save is not a feature.

### Describe the problem I'm guessing there's an attribute used by the "Recent" tab that isn't being persisted. ### To Reproduce 1. Modify some pages 2. Observe Recent tab 3. Now save 4. The saved Feather Wiki has an empty Recent tab ### Expected behavior The items listed in the recent tab should persist after a save. ### Details (please complete the following information) - I am using this build: Warbler - I am using this version: 1.7.0 - I am using this browser: Chrome ### Additional context I might be confused about the expected behavior, but it seems like the Recent tab being empty after a save is not a feature.
sbaird added the
bug
label 2023-10-23 17:21:46 +00:00

If you look at FW.state.recent.length after reloading, it's always zero.

If you look at `FW.state.recent.length` after reloading, it's always zero.

Weird! I had put in code to make sure it loaded, but I guess not the right way. I'll take a look.

Edit: Are you talking about saving a page or after saving the wiki and loading the newly saved wiki?

Weird! I had put in code to make sure it loaded, but I guess not the right way. I'll take a look. Edit: Are you talking about saving a page or after saving the wiki and loading the newly saved wiki?

@sbaird Oh my god, I just realized I made that change and uploaded it to the release on Codeberg but not to the download on the website 🤦‍♂️ I'll let you know when I've got it fixed—I've also got a bug I need to figure out for a 1.7.1 release anyway, so I'll include it there.

@sbaird Oh my god, I just realized I made that change and uploaded it to the release on Codeberg but not to the download on the website 🤦‍♂️ I'll let you know when I've got it fixed—I've also got a bug I need to figure out for a 1.7.1 release anyway, so I'll include it there.

Oh yeah I should have mentioned I was using this: https://feather.wiki/builds/FeatherWiki_Warbler.html

Oh yeah I should have mentioned I was using this: https://feather.wiki/builds/FeatherWiki_Warbler.html

Actually in hindsight I could have figured this out when troubleshooting since I wasn't able to access FW.state.getRecent(), but thought maybe it was set to private somehow... 😅

Actually in hindsight I could have figured this out when troubleshooting since I wasn't able to access `FW.state.getRecent()`, but thought maybe it was set to private somehow... 😅

@sbaird Ok, version 1.7.1 fixes this! And I even remembered to update the files on the website this time! 😆

I did also update the files in the 1.7.0 release to reflect this bug lol, so if you were to re-download, it would be the same as what you got from the website originally.

Plus FW.state.help.getRecent() has been removed again in favor of just populating it during the ONLOAD event 👍

@sbaird Ok, [version 1.7.1](https://codeberg.org/Alamantus/FeatherWiki/releases/tag/1.7.1) fixes this! And I even remembered to update the files on the website this time! 😆 I did also update the files in the 1.7.0 release to reflect this bug lol, so if you were to re-download, it would be the same as what you got from the website originally. Plus `FW.state.help.getRecent()` has been removed again in favor of just populating it during the `ONLOAD` event 👍

(1.7.1 is available now on https://tiddlyhost.com/sites/new fyi.)

(1.7.1 is available now on https://tiddlyhost.com/sites/new fyi.)
Sign in to join this conversation.
There is no content yet.