Import-and-overwrite button broken in Ruffled Wren 1.6.1

nosycat commented

2023-06-20 07:53:04 +00:00

Describe the problem

Trying to import another Feather Wiki file with the big red button in Settings has no effect, and shows an error in the browser console.

To Reproduce

Go to 'Wiki Settings'
Click on 'Import & Overwrite With Other Feather Wiki File'
Pick a file to open
The page title changes, but nothing else

Expected behavior

Import should complete normally.

Details (please complete the following information)

I am using this build: Ruffled Wren
I am using this version: 1.6.1
I am using this browser: Opera 78 and Firefox 102

Additional context

Copy-pasted from Opera's browser console:

FeatherWiki_ruffled-Wren.html:11 Uncaught (in promise) TypeError: a.indexOf is not a function
    at VM6 FeatherWiki_ruffled-Wren.html:11
    at Array.filter (<anonymous>)
    at P._t [as tidy] (VM6 FeatherWiki_ruffled-Wren.html:11)
    at Function.<anonymous> (VM6 FeatherWiki_ruffled-Wren.html:11)
    at R._emit (VM6 FeatherWiki_ruffled-Wren.html:1)
    at R.emit (VM6 FeatherWiki_ruffled-Wren.html:1)
    at l (VM6 FeatherWiki_ruffled-Wren.html:11)
    at Function.<anonymous> (VM6 FeatherWiki_ruffled-Wren.html:11)
    at R._emit (VM6 FeatherWiki_ruffled-Wren.html:1)
    at R.emit (VM6 FeatherWiki_ruffled-Wren.html:1)

(Firefox yields a similar error message, but with less useful context.)

### Describe the problem Trying to import another Feather Wiki file with the big red button in Settings has no effect, and shows an error in the browser console. ### To Reproduce 1. Go to 'Wiki Settings' 2. Click on 'Import & Overwrite With Other Feather Wiki File' 3. Pick a file to open 4. The page title changes, but nothing else ### Expected behavior Import should complete normally. ### Details (please complete the following information) - I am using this build: Ruffled Wren - I am using this version: 1.6.1 - I am using this browser: Opera 78 and Firefox 102 ### Additional context Copy-pasted from Opera's browser console: ``` FeatherWiki_ruffled-Wren.html:11 Uncaught (in promise) TypeError: a.indexOf is not a function at VM6 FeatherWiki_ruffled-Wren.html:11 at Array.filter (<anonymous>) at P._t [as tidy] (VM6 FeatherWiki_ruffled-Wren.html:11) at Function.<anonymous> (VM6 FeatherWiki_ruffled-Wren.html:11) at R._emit (VM6 FeatherWiki_ruffled-Wren.html:1) at R.emit (VM6 FeatherWiki_ruffled-Wren.html:1) at l (VM6 FeatherWiki_ruffled-Wren.html:11) at Function.<anonymous> (VM6 FeatherWiki_ruffled-Wren.html:11) at R._emit (VM6 FeatherWiki_ruffled-Wren.html:1) at R.emit (VM6 FeatherWiki_ruffled-Wren.html:1) ``` (Firefox yields a similar error message, but with less useful context.)

nosycat added the

bug

label 2023-06-20 07:53:04 +00:00

Alamantus commented

2023-06-20 12:29:29 +00:00

Owner

Hi @nosycat, would you be able to share the wiki you are trying to import? I've been able to use the Import and Overwrite button without an issue, i.e. to upgrade the main website.

strunevsky commented

2023-06-21 08:38:56 +00:00

Hi @Alamantus, I have the same issue and I suspect that the problem may be in this line of code:
d8473db104/index.js (L36)

// For arrays of strings (like tags) only
FW.tidy = ar => ar.map(v => v.trim()).filter((v, i) => v.length && a.indexOf(v) === i).sort();

'a' is not defined here

Hi @Alamantus, I have the same issue and I suspect that the problem may be in this line of code: https://codeberg.org/Alamantus/FeatherWiki/src/commit/d8473db104c602701d8aa312e44f927e8b6d6591/index.js#L36 ``` // For arrays of strings (like tags) only FW.tidy = ar => ar.map(v => v.trim()).filter((v, i) => v.length && a.indexOf(v) === i).sort(); ``` 'a' is not defined here

👀 1

nosycat commented

2023-06-21 11:45:33 +00:00

Poster

Oops, forgot to mention, it's the Tales of Space and Magic wiki. Same as always. Actually, let me attach a copy.

Oops, forgot to mention, it's the [Tales of Space and Magic](https://felix.plesoianu.ro/rpg/tosm-wiki.html) wiki. Same as always. Actually, let me attach a copy.

tosm-wiki.html

197 KiB

Alamantus commented

2023-06-21 14:39:50 +00:00

Owner

@strunevsky Oh, good catch, and right you are!! I had moved that from a different file and it looks like I totally missed that.

And thanks @nosycat! I'll definitely be getting a fix out for this ASAP.

@strunevsky Oh, good catch, and right you are!! I had moved that from a different file and it looks like I totally missed that. And thanks @nosycat! I'll definitely be getting a fix out for this ASAP.

Alamantus referenced this issue from a commit

2023-06-21 14:58:09 +00:00

Fix broken FW.tidy() after moving it (#107)

Alamantus referenced this issue from a commit

2023-06-21 15:07:57 +00:00

Fix tag bug in #107

Alamantus commented

2023-06-21 15:28:05 +00:00

Owner

Hey @nosycat and @strunevsky, thanks again for letting me know about this! I got the 1.6.2 release uploaded with the fix, and the website is updated as well.

Hey @nosycat and @strunevsky, thanks again for letting me know about this! I got the [1.6.2 release](https://codeberg.org/Alamantus/FeatherWiki/releases/tag/1.6.2) uploaded with the fix, and the website is updated as well.

👍 1 ❤️ 1

nosycat commented

2023-06-21 16:55:13 +00:00

Poster

Version 1.6.2 seems to work fine. Thank you very much!

strunevsky commented

2023-06-21 17:26:35 +00:00

Version 1.6.2 works fine for me too. Thank you!

Bearking commented

2023-06-21 20:45:32 +00:00

So, I this problem too and it occurred after I used the update extension to update my wiki on my tiddlyhost account. I didn't create a backup beforehand, I know, rookie mistake. Is there a way to get my info back?

Alamantus commented

2023-06-21 22:59:41 +00:00

Owner

Awesome, thanks for letting me know!

Alamantus closed this issue

2023-06-21 22:59:42 +00:00

sbaird commented

2023-06-22 03:50:29 +00:00

@Bearking If you tell me which site it is I might be able to help with the recovery.

Alamantus commented

2023-06-22 04:16:33 +00:00

Owner

Oops, sorry @Bearking, I didn't see your message before posting mine lol. If @sbaird can't help with the recovery, I can do some surgery on your wiki if you're able to get a download of it!

Alamantus reopened this issue

2023-06-22 04:16:34 +00:00

sbaird commented

2023-06-22 15:16:19 +00:00

@Bearking I took a guess which site you're talking about and recovered the previously saved version of it. Take a look at https://tiddlyhost.com/sites and you should see the restored version. The restored version is still FeatherWiki 1.6.0, but I think if you upgrade now using "Import and overwrite" with FeatherWiki 1.6.2 it should work correctly.

Bearking commented

2023-06-22 15:49:35 +00:00

@sbaird I just checked the site you recovered and that is the one I needed. Thank you.

❤️ 1

Alamantus closed this issue

2023-06-27 22:48:47 +00:00

Import-and-overwrite button broken in Ruffled Wren 1.6.1 #107

Describe the problem

To Reproduce

Expected behavior

Details (please complete the following information)

Additional context